-
Notifications
You must be signed in to change notification settings - Fork 4.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution #4868
base: master
Are you sure you want to change the base?
Solution #4868
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job on implementing the calculateRentalCost
function! 🎉 Your code meets all the task requirements and constraints, with clear variable names and proper use of constants. The logic for applying discounts is correctly implemented, ensuring that each discount is applied only once. Keep up the excellent work! 😊
✨ Please rate this review in the Platform's notification center. I will be grateful for your feedback! ✨
if (days >= longRental) { | ||
totalPrice += cost * days - longTermDiscount; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for applying the long-term discount is correct, but ensure that the discount is only applied once. The current logic correctly applies the discount if the rental is 7 days or more.
if (days >= mediumRental) { | ||
totalPrice += cost * days - shortTermDiscount; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic for applying the medium-term discount is correct, but ensure that the discount is only applied once. The current logic correctly applies the discount if the rental is 3 to 6 days.
return totalPrice; | ||
} | ||
|
||
totalPrice += cost * days; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line correctly calculates the total price without any discount for rentals less than 3 days.
No description provided.